Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Vite to v5 #87

Merged
merged 1 commit into from
Dec 10, 2023
Merged

bump Vite to v5 #87

merged 1 commit into from
Dec 10, 2023

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Dec 10, 2023

With vite 5 it seems virtual modules does not work anymore inside node_modules, so, we need to patch ember-intl to not break.

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for ember-vite ready!

Name Link
🔨 Latest commit cfa3230
🔍 Latest deploy log https://app.netlify.com/sites/ember-vite/deploys/6575d6dac8d93a0009b23369
😎 Deploy Preview https://deploy-preview-87--ember-vite.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 10, 2023

Code Coverage Report

Coverage after merging vite-5 into master

97.66%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
addons
   ember-simple-auth.ts12, 16
.../Bootstrap
   index.ts50
.../Hot
🔴   index.ts ⬆️ 17.27%72.7387.5096, 97, 98, 99, ...
config
   registry.ts85, 99
   router.ts98.0897, 98
   utils.ts93.5557, 58, 59, 60, ...
helpers
   memory-usage.ts12, 18, 20, 30, ...
modifiers
   click-tracker.ts20, 21

bump vite to v5
bump node to v20
@lifeart lifeart merged commit 63519d5 into master Dec 10, 2023
8 checks passed
@lifeart lifeart deleted the vite-5 branch December 10, 2023 15:27
@lifeart
Copy link
Owner Author

lifeart commented Dec 14, 2023

Just note for readers, references: I see bundle size grow for this update:

vite v4.3.9
image

vite v5.0.7
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant